Update to lxml 6.0.0 and fix GitHub Actions #353

TomiBelan · 2025-07-07T00:16:09Z

This PR updates the libxml2+libxslt versions to be compatible with lxml 6.0.0, and fixes various other issues that were preventing manylinux wheels from being built (per @mxamin #344 (comment)), as well as other broken CI workflows.

Fixes Release 1.3.15 missing wheels for linux #344
Fixes Reports of errors with version 1.3.15 #345
Fixes Error on installing xmlsec 1.3.15 #349
Fixes Plans for support for Python 3.12+? #350
Fixes 'lxml & xmlsec libxml2 library version mismatch #351
Updates Incompatibility with lxml wheels on Python 3.13 – request for official compatibility matrix #352
(Side note: It does NOT fix Windows builds. Changing wheels.yml from windows-2019 to windows-2022 is not sufficient, because the prebuilt libraries at https://github.com/mxamin/python-xmlsec-win-binaries are too old and the compiler version does not match. Someone else has to fix that.)

…xml2" This reverts commit 967754b.

As suggested in xmlsec#344 (comment)

The server at www.aleksey.com (Cloudflare?) returns 403 Forbidden errors for some combination of: - missing User-Agent header - GitHub Actions CI runner IP address range - TLS settings (version, cipher suite) used by Python <= 3.9

This solves the warning: configure: WARNING: you should use --build, --host, --target

for more information, see https://pre-commit.ci

TomiBelan · 2025-07-07T00:24:33Z

You can check the working wheel build at https://github.com/TomiBelan/python-xmlsec/actions/runs/16104214310
or other workflows at https://github.com/TomiBelan/python-xmlsec/actions

mxamin · 2025-07-09T08:08:26Z

@TomiBelan Looks good, you can merge that.

TomiBelan · 2025-07-09T13:08:02Z

@mxamin Thanks but I don't have write access to your repo. You have to merge it.

TomiBelan · 2025-07-09T13:17:03Z

Thanks for reviewing it! :)
I guess the next step is to make a new release, in order to really fix the linked issues. Although, for Windows wheels, I'm not sure, you might need to update the Windows libraries first (especially libxml 2.14.4).

potiuk · 2025-07-09T13:19:23Z

Thanks for reviewing it! :) I guess the next step is to make a new release, in order to really fix the linked issues. Although, for Windows wheels, I'm not sure, you might need to update the Windows libraries first (especially libxml 2.14.4).

Yep. Would be great to get notified when it is released indeed and unblock apache/airflow#52539 as well

mxamin · 2025-07-09T13:55:07Z

Thanks for reviewing it! :) I guess the next step is to make a new release, in order to really fix the linked issues. Although, for Windows wheels, I'm not sure, you might need to update the Windows libraries first (especially libxml 2.14.4).

Yep. Would be great to get notified when it is released indeed and unblock apache/airflow#52539 as well

I'm actively working on that during summer and planning to release it soon, but first I need to solve the libxml2 incompatibility issue.

TomiBelan · 2025-07-09T14:00:29Z

I'm actively working on that during summer and planning to release it soon, but first I need to solve the libxml2 incompatibility issue.

libxml2 incompatibility issue? Tell me more. Is there some other issue this PR doesn't fix? I can try and take a look.

I thought Windows wheels won't be a problem, because the python-xmlsec 1.3.15 release contained them. I assume someone built them manually.

If it might take a while until the release, you might want to reopen #344 for now. (I don't have access.)

TomiBelan · 2025-07-09T14:47:29Z

(especially libxml 2.14.4).

Correction - I just found that lxml 6.0.0 windows wheels use "libxml2 2.11.9, libxslt 1.1.39 and libiconv 1.17" (link). Sorry for any confusion.

mxamin · 2025-07-09T14:56:57Z

I'm actively working on that during summer and planning to release it soon, but first I need to solve the libxml2 incompatibility issue.

libxml2 incompatibility issue? Tell me more. Is there some other issue this PR doesn't fix? I can try and take a look.

I thought Windows wheels won't be a problem, because the python-xmlsec 1.3.15 release contained them. I assume someone built them manually.

If it might take a while until the release, you might want to reopen #344 for now. (I don't have access.)

Take a look at this issue: #283
I guess I can take care of windows wheels, I'll take a look.

On the second thought I probably release a new version soon and solve the incompatibility issue later. It requires lots of changes and cleanup.

TomiBelan · 2025-07-09T15:12:31Z

I see... That's beyond my ability to fix. 😅
Releasing this soon and solving the incompatibility later sounds like a good plan to me. Good luck!
I'll send you a python-xmlsec-win-binaries PR in a moment. (it's pretty trivial though, not like this one)

mxamin · 2025-07-09T15:36:23Z

I see... That's beyond my ability to fix. 😅 Releasing this soon and solving the incompatibility later sounds like a good plan to me. Good luck! I'll send you a python-xmlsec-win-binaries PR in a moment. (it's pretty trivial though, not like this one)

Nice, I created a PR but I'm not sure if it's gonna pass. Feel free to create a PR and I'm gonna use yours if it works :)

TomiBelan · 2025-07-09T21:59:10Z

(it's pretty trivial though, not like this one)

Narrator: looks straight at camera

I made some progress. (draft, CI, draft, CI) For some reason, every build takes 1 hour. Very annoying.

Turns out that xmlsec 1.3.7 switched the default windows backend from openssl to mscng. Which do you prefer: Should python-xmlsec follow suit, or switch it back to openssl?

Also, JFYI, xmlsec 1.3.6 disabled iconv on windows by default. But iconv is apparently also used by libxml2, so, might as well keep it enabled.

mxamin · 2025-07-09T22:43:23Z

(it's pretty trivial though, not like this one)

Narrator: looks straight at camera

I made some progress. (draft, CI, draft, CI) For some reason, every build takes 1 hour. Very annoying.

Turns out that xmlsec 1.3.7 switched the default windows backend from openssl to mscng. Which do you prefer: Should python-xmlsec follow suit, or switch it back to openssl?

Also, JFYI, xmlsec 1.3.6 disabled iconv on windows by default. But iconv is apparently also used by libxml2, so, might as well keep it enabled.

openssl vs mscng: I guess we'd better follow xmlsec and use mscng if possible. Also I have no objection to continue using openssl. I'll leave it to you to decide.
iconv: I see no harm to keep it.

TomiBelan · 2025-07-10T00:19:58Z

OK, I got it to work. (successful build)

Do this next:

Review and merge Update libraries, support ARM, force OpenSSL backend mxamin/python-xmlsec-win-binaries#4
Wait for GitHub Actions to build it
Create a release in python-xmlsec-win-binaries and add the built zip files
Add this commit TomiBelan@24affa7 to your PR Fix windows wheels and add ARM support #354 (or just copy changes manually)
Set release_url in setup.py to the new release you created
If CI becomes green, merge it
Release python-xmlsec

mxamin · 2025-07-10T12:25:35Z

OK, I got it to work. (successful build)

Do this next:

Review and merge Update libraries, support ARM, force OpenSSL backend mxamin/python-xmlsec-win-binaries#4

Wait for GitHub Actions to build it

Create a release in python-xmlsec-win-binaries and add the built zip files

Add this commit TomiBelan@24affa7 to your PR Fix windows wheels and add ARM support #354 (or just copy changes manually)

Set release_url in setup.py to the new release you created

If CI becomes green, merge it

Release python-xmlsec

Thanks a lot for the help, the new release is out.

TomiBelan · 2025-07-10T12:37:10Z

Excellent!

Was there some problem with Windows ARM that made you revert it? (Personally I don't care, it can wait for the next release.)

I think https://pypi.org/project/xmlsec/#files is missing the sdist (source distribution).

mxamin · 2025-07-10T12:41:19Z

Oh, my bad. I forgot to add the arm back after testing that :(
I'll add it in the next release.

I'll add the sdist.zip

TomiBelan and others added 12 commits July 5, 2025 16:15

Revert "Ensure we don't use the wheel, which uses older versions of l…

f3f9ba3

…xml2" This reverts commit 967754b.

Update library versions based on lxml 6.0.0

40b755f

Enable ripemd60

6e691b3

As suggested in xmlsec#344 (comment)

Fix failing tests in sdist workflows

d6ea8de

Show stdout in setup.py, not only stderr

bcd364c

Download xmlsec1 releases from GitHub

c63a486

The server at www.aleksey.com (Cloudflare?) returns 403 Forbidden errors for some combination of: - missing User-Agent header - GitHub Actions CI runner IP address range - TLS settings (version, cipher suite) used by Python <= 3.9

Fix empty argument to ./configure

7f1e1d9

This solves the warning: configure: WARNING: you should use --build, --host, --target

Update wheel availability based on lxml 6.0.0

9c11b8f

Fix linuxbrew workflow

c3f3df2

Fix macosx workflow

749da11

Fix manylinux workflow

4f21315

[pre-commit.ci] auto fixes from pre-commit.com hooks

8f04791

for more information, see https://pre-commit.ci

TomiBelan mentioned this pull request Jul 7, 2025

Unable to build xmlsec version 1.3.15 #347

Open

mxamin approved these changes Jul 7, 2025

View reviewed changes

mxamin merged commit 3f1dfe5 into xmlsec:master Jul 9, 2025
79 of 91 checks passed

TomiBelan mentioned this pull request Jul 9, 2025

'xmlSecMSCngTransformEcdsaSha224Id': undeclared identifier lsh123/xmlsec#935

Closed

Update to lxml 6.0.0 and fix GitHub Actions #353

Update to lxml 6.0.0 and fix GitHub Actions #353

Uh oh!

Conversation

TomiBelan commented Jul 7, 2025

Uh oh!

TomiBelan commented Jul 7, 2025

Uh oh!

mxamin commented Jul 9, 2025

Uh oh!

TomiBelan commented Jul 9, 2025

Uh oh!

Uh oh!

TomiBelan commented Jul 9, 2025

Uh oh!

potiuk commented Jul 9, 2025

Uh oh!

mxamin commented Jul 9, 2025

Uh oh!

TomiBelan commented Jul 9, 2025

Uh oh!

TomiBelan commented Jul 9, 2025

Uh oh!

mxamin commented Jul 9, 2025

Uh oh!

TomiBelan commented Jul 9, 2025

Uh oh!

mxamin commented Jul 9, 2025

Uh oh!

TomiBelan commented Jul 9, 2025

Uh oh!

mxamin commented Jul 9, 2025

Uh oh!

TomiBelan commented Jul 10, 2025

Uh oh!

mxamin commented Jul 10, 2025

Uh oh!

TomiBelan commented Jul 10, 2025

Uh oh!

mxamin commented Jul 10, 2025

Uh oh!

Uh oh!